Added new Lambda Multiple Span Flag #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangzlei
approved these changes
Mar 10, 2025
yiyuan-he
pushed a commit
to yiyuan-he/aws-otel-python-instrumentation
that referenced
this pull request
Mar 11, 2025
*Description of changes:* Added a new lambda span processor that 1. Overwrites the INTERNAL API Span (example: `opentelemetry.instrumentation.flask`) to SERVER 2. adds a new flag to Lambda Spans if there are multiple server spans in the trace. Also updated the Operation Name logic so that if the span is an `opentelemetry.instrumentation.flask` span, the operation name is the API Route instead of the FunctionHandler operation name. This makes it easier to identify that the Span is an API span in the Application Signals console. *Testing:* Added unit test to test processor. Also tested by creating a lambda layer. The lambda span does have the new flag and the operation name for the API Span is the API Route. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Added a new lambda span processor that
opentelemetry.instrumentation.flask) to SERVERAlso updated the Operation Name logic so that if the span is an
opentelemetry.instrumentation.flaskspan, the operation name is the API Route instead of the FunctionHandler operation name. This makes it easier to identify that the Span is an API span in the Application Signals console.Testing:
Added unit test to test processor. Also tested by creating a lambda layer. The lambda span does have the new flag and the operation name for the API Span is the API Route.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.